Repository navigation
Allow selectcols to have tuples as "indices" argument - #992
Merged
Merged
Conversation
Member
Author
|
@OkonSamuel Any chance you could take a look at this? |
Member
Author
|
@MilesCranmer Would you be able to review this? |
Contributor
|
Apart from that it seems good to me |
Member
Author
|
Thanks @MilesCranmer for the lightning-speed review. Outside reviews are essential for maintaining quality of the software and I appreciate them very much. I've adopted your good suggestions. |
Contributor
|
FYI this PR - and hence the 1.8.0 release - are broken: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #991. It also fixes an unrelated test that seems to have been broken by recent Julia update. Something about the behaviour of
@doc, it seems.@OkonSamuel Let me know if you had a better suggestion for this PR. Otherwise, please review.